Re: [GNU Autoconf 2.68] testsuite: 1 10 11 12 14 16 17 20 22 24 25 27 28 32 33 36 38 208 211 212 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 277 278 279 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 485 failed

[Eric Blake]

On 03/07/2012 10:32 AM, Peter O'Gorman wrote:
> 
> I'd like confirmation from Martin that this is the issue first :-)

Actually, I reproduced the issue on Fedora 16, by doing:

diff --git i/tests/local.at w/tests/local.at
index eb01cc0..2b0d136 100644
--- i/tests/local.at
+++ w/tests/local.at
@@ -50,7 +50,7 @@ AT_CHECK([$at_diff "$1" "$2"])
 # otherwise, do nothing.
 m4_define([AT_CHECK_SHELL_SYNTAX],
 [AT_SKIP_IF([test "$ac_cv_sh_n_works" != yes])
-AT_CHECK([/bin/sh -n $1])])
+AT_CHECK([/bin/ksh -n $1])])

 m4_define([AT_CHECK_PERL_SYNTAX],
 [AT_CHECK([autom4te_perllibdir=$abs_top_srcdir/lib $PERL -c
"$abs_top_builddir"/bin/$1],

> 
> If it is then the patch is trivial:

> -      test -n "${.sh.version}" # ksh93; put this last since its syntax
> is dodgy
> +      test -n "${ZSH_VERSION+set}"  # zsh

I'd rather keep the ksh check (it actually isn't erroring out), so I am
applying this instead:


From 32491fcb90ffa80221b2ec651ac9e4d852cad9ff Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Wed, 7 Mar 2012 10:40:11 -0700
Subject: [PATCH] tests: ignore ksh -n warnings

Recent ksh is noisy:

$ ksh -nc '``'; echo $?
ksh: warning: line 1: `...` obsolete, use $(...)
0

* tests/local.at (AT_CHECK_SHELL_SYNTAX): Ignore noisy ksh on.
Reported by Martin Zaun.

Signed-off-by: Eric Blake <address@hidden>
---
 tests/local.at |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/local.at b/tests/local.at
index eb01cc0..66027e8 100644
--- a/tests/local.at
+++ b/tests/local.at
@@ -47,10 +47,11 @@ AT_CHECK([$at_diff "$1" "$2"])
 # AT_CHECK_SHELL_SYNTAX(PROGRAM)
 # ------------------------------
 # If the shell handles `-n' well, use it to check the syntax of PROGRAM;
-# otherwise, do nothing.
+# otherwise, do nothing.  ksh93 -n also spits outs loads of warnings
+# about older constructs, but we don't care about the warnings.
 m4_define([AT_CHECK_SHELL_SYNTAX],
 [AT_SKIP_IF([test "$ac_cv_sh_n_works" != yes])
-AT_CHECK([/bin/sh -n $1])])
+AT_CHECK([/bin/sh -n $1], [], [], [ignore])])

 m4_define([AT_CHECK_PERL_SYNTAX],
 [AT_CHECK([autom4te_perllibdir=$abs_top_srcdir/lib $PERL -c
"$abs_top_builddir"/bin/$1],
-- 
1.7.7.6

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature