Re: completion always appends /

[Harald Koenig]

Hello GNU Bash developers!


a week ago I've send you a bug report and as follow-up the fix patch below,
but so far I did not get any reply, not even an ACK or ticket number
that anyone received my mails.

I would like to roll out that bug fix and did hope that I'll get

a) any reaction and comment on my report and esp. on the patch
b) this will be a an official patch before I roll out my new binaries.
   otherwise I'll have to revert my patch later and apply your
   (possibly different and better) fix later, resulting in another rollout
   which I'd like to avoid...
 

anyone reading bash-bug mails these day ?
any comments or suggestions/optimizations for this patch ?


thanks for any hint!


On Aug 15, Harald Koenig wrote:

> -------------------------------------------------------------------------------
> --- lib/readline/complete.c~  2006-07-28 17:35:49.000000000 +0200
> +++ lib/readline/complete.c   2007-08-15 11:14:20.000000000 +0200
> @@ -1528,6 +1528,8 @@
>    else if (rl_completion_suppress_append == 0 && 
> rl_completion_append_character)
>      temp_string[temp_string_index++] = rl_completion_append_character;
>  
> +  rl_completion_append_character = ' ';
> +
>    temp_string[temp_string_index++] = '\0';
>  
>    if (rl_filename_completion_desired)
> -------------------------------------------------------------------------------
> 
> or
> 
> -------------------------------------------------------------------------------
> --- lib/readline/complete.c~  2006-07-28 17:35:49.000000000 +0200
> +++ lib/readline/complete.c   2007-08-15 11:14:20.000000000 +0200
> @@ -1569,6 +1569,8 @@
>       rl_insert_text (temp_string);
>      }
>  
> +  rl_completion_append_character = ' ';
> +
>    return (temp_string_index);
>  }
>  
> -------------------------------------------------------------------------------

Harald Koenig
-- 
"I hope to die                                      ___       _____
before I *have* to use Microsoft Word.",           0--,|    /OOOOOOO\
Donald E. Knuth, 02-Oct-2001 in Tuebingen.        <_/  /  /OOOOOOOOOOO\
                                                    \  \/OOOOOOOOOOOOOOO\
                                                      \ OOOOOOOOOOOOOOOOO|//
Harald Koenig                                          \/\/\/\/\/\/\/\/\/
science+computing ag                                    //  /     \\  \
koenig@science-computing.de                            ^^^^^       ^^^^^
-- 
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Florian Geyer,
Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Prof. Dr. Hanns Ruder
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196