Re: [PATCH] bracketed paste support

[Daniel Colascione]

On 10/29/2014 08:49 PM, Chet Ramey wrote:
>> On 10/27/14, 6:35 PM, Daniel Colascione wrote:
>>> This patch adds support for "bracketed paste mode" to readline. In
>>> this mode, readline instructs the terminal to wrap pasted strings in
>>> special control sequences so that programs can distinguish them from
>>> typed input. 
>>
>> Thanks for the contribution.  I'll look at the code; the approach seems
>> sound.
> 
> It went in very easily, though I changed some things around.  This
> will be in the next release of bash and readline.

The code appeared in the snapshot, so I was able to look at how you
"changed some things around". You removed the code that tries to
determine whether a terminal actually supports the feature; instead, you
blindly send the enable sequence to *any* terminal when
enable-bracketed-paste is enabled, with potentially unknown consequences
on those terminals.

There's a comment in the code that indicates you expect users to enable
the feature only on terminals where it's supported. I don't think it's
reasonable to expect people to maintain a terminal database in their
inputrc files.

You also know very well that people are going to just set the feature to
enabled in their configurations, test it, and see it work, all without
considering whether they should enable this feature in a
terminal-type-dependent conditional. Then they'll wonder why parts of
their system silently break.

Please restore the part of my patch,
rl_bracketed_paste_probably_supported, that detects terminal support for
this feature.

signature.asc
Description: OpenPGP digital signature