Re: Performance regression for hash_insert when using bash's internal malloc

[Eduardo A . Bustamante López]

Nevermind, I was told by someone from #bash in IRC that this issue has been
raised multiple times:

* http://lists.gnu.org/archive/html/bug-bash/2014-01/msg00126.html
* http://lists.gnu.org/archive/html/bug-bash/2011-05/msg00020.html
* http://lists.gnu.org/archive/html/bug-bash/2013-05/msg00003.html



Compiling with:
    CFLAGS='-O2' ./configure --with-bash-malloc=yes 
--prefix=/tmp/bash/devel-nodebug-O2 && make DEBUG= MALLOC_DEBUG= install

Changing the test:

dualbus@hp ~ % diff -u test.old test 
--- test.old    2014-11-22 17:09:35.413970597 -0600
+++ test    2014-11-22 17:10:50.730915097 -0600
@@ -16,6 +16,7 @@
 /tmp/bash/4.3-rc2-O2/bin/bash
 /tmp/bash/devel-O2/bin/bash
 /tmp/bash/devel-nobashmalloc-O2/bin/bash
+/tmp/bash/devel-nodebug-O2/bin/bash
 )
 
 cd "$tmpdir" || exit 1
@@ -80,7 +81,8 @@
 plot "sh-0.dat" using 2:($1*1000) title "master", \
      "sh-1.dat" using 2:($1*1000) title "4.3", \
      "sh-2.dat" using 2:($1*1000) title "devel", \
-     "sh-3.dat" using 2:($1*1000) title "devel no-bash-malloc"
+     "sh-3.dat" using 2:($1*1000) title "devel no-bash-malloc", \
+     "sh-4.dat" using 2:($1*1000) title "devel no-debug"
 PLOT
 
 echo "image: $tmpimg"

Gives: http://imgur.com/LDBWeSr

(also attached)


So, in conclusion: It's not a regression, you can easily turn off the
instrumentation to get the normal performance.


Sorry for the noise :)

graph.png
Description: PNG image