[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug with multiline strings parsing and single-quoted !
From: |
Eduardo A . Bustamante López |
Subject: |
Re: bug with multiline strings parsing and single-quoted ! |
Date: |
Wed, 3 Dec 2014 03:19:53 -0600 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 03, 2014 at 08:57:26AM +0100, Piotr Grzybowski wrote:
> Hey,
>
> I think in this case, history_expand lib/readline/histexpand.c:905 is
> invoked with hstring="b\" | echo '!'", and goes wrongly into history
> expansion.
> Not that I know how to fix it ;-)
Yes, the issue is tricky, because you don't have access to the whole buffer
there (shell_getc), just to the current line (shell_input_line), but the
current line is a fragment of the whole command.
What I don't understand is why bash does history expansion inside shell_getc,
shouldn't it be easier to do it once you have the whole thing?
zsh does that:
| dualbus@hp ~ % echo x
| x
| dualbus@hp ~ % echo "
| dualbus@hp ~ dquote> !!
| dualbus@hp ~ dquote> "
| echo "
| echo x
| "
|
| echo x
Also tcsh:
| dualbus@hp ~ % tcsh
| hp:~> echo x
| x
| hp:~> echo "\
| ? !!\
| ? "
| echo "\
| echo x\
| "
|
| echo x
|
| hp:~>
vs bash:
| dualbus@hp:~$ echo x
| x
| dualbus@hp:~$ echo "
| > !!
| echo "
|
| echo
| dualbus@hp:~$
It seems hard to change that, though.
- bug with multiline strings parsing and single-quoted !, gennady . kupava, 2014/12/02
- Re: bug with multiline strings parsing and single-quoted !, Ángel González, 2014/12/02
- Re: bug with multiline strings parsing and single-quoted !, Piotr Grzybowski, 2014/12/03
- Re: bug with multiline strings parsing and single-quoted !,
Eduardo A . Bustamante López <=
- Re: bug with multiline strings parsing and single-quoted !, Piotr Grzybowski, 2014/12/03
- Re: bug with multiline strings parsing and single-quoted !, Chet Ramey, 2014/12/03
- Re: bug with multiline strings parsing and single-quoted !, Gennady Kupava, 2014/12/03
- Re: bug with multiline strings parsing and single-quoted !, Greg Wooledge, 2014/12/03
- Re: bug with multiline strings parsing and single-quoted !, Linda Walsh, 2014/12/06