[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: readline-6.3: update config.h.in
|
From: |
Andreas Schwab |
|
Subject: |
Re: readline-6.3: update config.h.in |
|
Date: |
Mon, 20 Apr 2015 08:59:59 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Chet Ramey <chet.ramey@case.edu> writes:
> On 4/19/15 2:00 PM, Andreas Schwab wrote:
>> The config.h.in file in the standalone readline distribution is missing
>> a lot of templates. It should really be generated by autoheader.
>>
>> --- readline-6.3/config.h.in.~1~ 2012-01-18 16:22:13.000000000 +0100
>> +++ readline-6.3/config.h.in 2015-04-19 19:39:13.215290092 +0200
>> @@ -6,6 +6,14 @@
>>
>> #undef _FILE_OFFSET_BITS
>>
>> +#undef __EXTENSIONS__
>> +#undef _ALL_SOURCE
>> +#undef _GNU_SOURCE
>> +#undef _POSIX_SOURCE
>> +#undef _POSIX_1_SOURCE
>> +#undef _POSIX_PTHREAD_SEMANTICS
>> +#undef _TANDEM_SOURCE
>> +
>
> Readline configure.ac doesn't call AC_USE_SYSTEM_EXTENSIONS.
Yes, it does, even if indirectly. The configure script defines them, so
you need to add the templates.
> Readline doesn't actually call any of these functions, and even though
> BASH_CHECK_MULTIBYTE tests for them, it doesn't matter whether or not it
> finds them.
If you would use autoheader you'll just get what you ask for, no second
hand guessing which will be wrong sooner or later.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."