Re: Hang in bgp_delete

[Graham Northup]

On 02/16/2017 11:25 AM, Chet Ramey wrote:
> On 2/11/17 5:04 PM, Graham Northup wrote:
> 
>> Bash Version: 4.4
>> Patch Level: 11
>> Release Status: release
>>
>> Description:
>>
>> I'm getting a mysterious hang on one of our Arch Linux machines for a
>> particular, rather simple script; getting a debugger attached to the
>> process after building some debugging symbols, I tracked the hang down
>> to this loop in bgp_delete (with some minor formatting):
> 
> It seems obvious in retrospect that the cause is in bgp_add, where there's
> no check for the hashed pid colliding with the index into the pidstat list.
> Here's a patch that avoids that issue and catches the symptom you found in
> case the cause is something else.
> 
> Chet
> 

Just built bash with the patch applied; I'll be checking in every couple
of days to see if that happens again. (As I mentioned previously, it's a
bit hard to instigate; consider no news to be good news :) .

Thanks for the fix!
- Graham

signature.asc
Description: OpenPGP digital signature