[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add nofirstword completion option
From: |
Luca Boccassi |
Subject: |
Re: [PATCH] Add nofirstword completion option |
Date: |
Tue, 12 Jun 2018 18:28:54 +0100 |
On Fri, 2018-06-08 at 11:03 -0400, Chet Ramey wrote:
> On 6/8/18 10:40 AM, Luca Boccassi wrote:
>
> > Any chance you had a sec to look at the diff? Would love some
> > feedback!
>
> I'm going to try and look at it this weekend. It's been a busy couple
> of
> months.
Hi Chet,
I've seen that the change is now in the devel branch, thank you so
much!
I also like way more the new option name, definitely clearer :-)
One difference I noticed with the previous version is that when trying
to complete a command when the line starts with an empty space (eg: to
avoid the history) the initial word programmable completion doesn't
happen.
It seems to hit the following branch:
else if (s >= e && n[0] == '\0' && text[0] == '\0' && start > 0)
{
foundcs = 0; /* empty command name following assignments */
in_command_position = was_assignment;
}
Given was_assignment is 0, then the programmable completion is later
not attempted.
Since that branch matches an empty command name, should it perhaps call
the EMPTYCMD completion?
Something like:
else if (s >= e && n[0] == '\0' && text[0] == '\0' && start > 0)
{
foundcs = 0; /* empty command name following assignments */
in_command_position = was_assignment;
+ if (have_progcomps)
+ prog_complete_matches = programmable_completions (EMPTYCMD, text,
s, e, &foundcs);
}
Or is there a better solution?
Thanks!
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
- Re: [PATCH] Add nofirstword completion option, Luca Boccassi, 2018/06/01
- Re: [PATCH] Add nofirstword completion option, Luca Boccassi, 2018/06/08
- Re: [PATCH] Add nofirstword completion option, Chet Ramey, 2018/06/08
- Re: [PATCH] Add nofirstword completion option,
Luca Boccassi <=
- Re: [PATCH] Add nofirstword completion option, Chet Ramey, 2018/06/12
- Re: [PATCH] Add nofirstword completion option, Luca Boccassi, 2018/06/12
- Re: [PATCH] Add nofirstword completion option, Chet Ramey, 2018/06/12
- Re: [PATCH] Add nofirstword completion option, Luca Boccassi, 2018/06/19
- Re: [PATCH] Add nofirstword completion option, Chet Ramey, 2018/06/19