Re: errno not restore before printing error in exec_builtin

[Emanuele Torre]

On Mon, Oct 28, 2024 at 12:47:53AM +0100, Emanuele Torre wrote:
>      }
>    else
> -    file_error (command);
> +    {
> +      errno = opt;
> +      file_error (command);
> +    }
>  

I just thought that perhaps this branch was supposed to print errors for
the executable_file() function call above, so maybe the correct fix is
to change  else  =>  "else if (errno)"  instead of restoring it.

Anyway, that does not address that this if-elseif-else block always
prints duplicate errors. I have not found any case in which after
shell_execve() is called, this code print an error that is not a
duplicate.

o/
 emanuele6