Re: make test errata

[Chet Ramey]

On 12/14/24 6:18 AM, Martin D Kealey wrote:

> Where there are some “expected” differences, could these be filtered? In
> particular,
>
>     - sort the output of “trap” alphabetically, rather than leave it in
>     numeric signal-number order?

I'll look at this, this might be useful.

>     - compare whitespace-agnostic tests using “diff -w” or “diff -b”?

There are a couple of functions in test-glue-functions that can do this
where needed.

>     - if possible compare error codes (like EINVAL) rather than
>     system-dependent messages?

In most cases, this isn't reflected in the exit status of the command
or expansion. My recent changes to look for any (rather than specific)
error output should be good enough.

> Could tests that depend on system facilities or build options be disabled,
> or have the warnings hidden when they should not be applicable:
>
>     - non-unicode locales are becoming less common, so in run-intl, exclude
>     the 400-odd tests that depend on non-unicode multibyte encodings, or limit>     tests to those that are compatible with $LANG from the build user? 
(I don't
>     have a terminal that can display BIG5 or SJIS, and even Latin-1 is awkward.)

Your experience is not universal; those encodings are still used. There
is already code in there that warns about and skips tests if the
environment doesn't have some of the more esoteric locales.

> conversely:
>
>     - don't warn about needing arrays unless bash is configured without
>     support for arrays
>     - don't warn about needing process substitutions unless bash is
>     configured without support for process substitutions or is being tested on
>     a system that lacks ‘/dev/fd’ or equivalent;
>     - don't warn about needing BASH_ARGV unless bash is configured without
>     support for debugging
>
> I'm prepared to submit patches to implement these if you could give me some
> guidance on which of them you would accept (or not).

How would you implement tests for the missing features? Let's start there.

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

OpenPGP_signature.asc
Description: OpenPGP digital signature