RE: ia64/ld/bfd pltoff problem

[Jim Wilson]

On Tue, 2004-06-29 at 17:45, Belochapka, Konstantin wrote:
> Test case for this problem:

Thanks.

I see that we current only call get_pltoff from
elfNN_ia64_create_dynamic_sections, which is only called for a shared
link.  So for a non-shared link, we need to call get_pltoff in
elfNN_ia64_check_relocs which is what you did.  I wrote my patch a bit
differently though, patterning it after the existing code to call
get_got, get_fptr, etc.  We set a variable to the result of get_pltoff,
so that we will call get_pltoff at most once per elfNN_ia64_check_relocs
call.  Otherwise, if there are a lot of pltoff relocs, we would end up
with a lot of get_pltoff calls, and that could slow down the linker.

I suspect that the get_pltoff call in elfNN_ia64_create_dynamic_sections
is no longer necessary, but it is safer and simpler to leave it there. 
We already have redundant code to create a got section there; it is
redundant with the code in get_got.  So at least the got and pltoff code
is consistent.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

patch.pltoff
Description: Text document