[Bug gas/619] New: lcomm is not working if no comma is given before parameter starts

[lts-rudolph at gmx dot de]

In gas version 2.14 it is correct to give the following line:
.lcomm varname (2)
in version 2.15 and above (CVS HEAD) this runs into error:
x.s:2: Error: missing size expression

The code in gas/read.c gives the possibility to give the line without a comma
in function "s_comm_internal"
<snip>
  /* Accept an optional comma after the name.  The comma used to be
     required, but Irix 5 cc does not generate it for .lcomm.  */
  if (*input_line_pointer == ',') 
    input_line_pointer++;
<snap>

As we can see the comma is not optional anymore. I tried to catch the problem
and found that the first "(" is eaten before "s_comm_internal" is entered:
The given file:
<start file>
.lcomm test2, (2)
.lcomm test1 (2)
<end file>
results in the following input_line_pointer string:
[0]   [28](   [32]2   [29])   
[0]   [32]2   [29])   
in [] the value is hex, followed by the ascii output until newline is present.

As you can see the first brace in second line was eaten before. Giving another
brace will also run into trouble. Sorry that I have not found the point where
the function is called so that I have not found the problem :-(

I did not really know if this is important, but the code actually give me
the idea that the comma is optional but a line with missing comma did not work.

As the comment for the "optional" comma gives the problem to irix 5 it is maybe
a problem. 


Thanks
   Klaus

-- 
           Summary: lcomm is not working if no comma is given before
                    parameter starts
           Product: binutils
           Version: 2.15
            Status: NEW
          Severity: minor
          Priority: P2
         Component: gas
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: lts-rudolph at gmx dot de
                CC: bug-binutils at gnu dot org
  GCC host triplet: i386-linux-gnu
GCC target triplet: avr


http://sources.redhat.com/bugzilla/show_bug.cgi?id=619

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.