[Bug binutils/716] strip doesn't maintain /LARGEADDRESSAWARE flag (mingw build, Windows 2000)

[Jan dot Nijtmans at xs4all dot nl]

------- Additional Comments From Jan dot Nijtmans at xs4all dot nl  2005-02-11 
22:41 -------
Subject: Re:  strip doesn't maintain /LARGEADDRESSAWARE
 flag   (mingw build, Windows 2000)

nickc at redhat dot com wrote:
 >   /* XXX: Should we be copying other pe_data() fields as well ?  */
 >   if (pe_data (obfd) != NULL && pe_data (ibfd) != NULL
 >       && pe_data (obfd)->real_flags == 0
 >       && pe_data (ibfd)->real_flags != 0)
 >     pe_data (obfd)->real_flags = pe_data (ibfd)->real_flags;

Even more KISS-like:

    if (pe_data (obfd) != NULL && pe_data (ibfd) != NULL
        && (pe_data (obfd)->real_flags & 0x20))
      pe_data (obfd)->real_flags |= 0x20;


But I'm not sure as well! How about big-endian vs. little-endian? I
don't know the code (and the PE format) well enough to give good
advise to you about this. So, indeed, it is better to be safe than
sorry.

Regards,
          Jan Nijtmans


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=716

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.