[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug binutils/5713] strings: use '-0' as option will meet infinite loop
From: |
nickc at redhat dot com |
Subject: |
[Bug binutils/5713] strings: use '-0' as option will meet infinite loop |
Date: |
15 Feb 2008 10:25:13 -0000 |
------- Additional Comments From nickc at redhat dot com 2008-02-15 10:25
-------
Hi Chu,
Thanks for pointing that out. In fact the integer_arg() function is
completely redundant as the C library function strtoul() does everything that is
needed. So I have applied a revised version of the patch which removes the
function entirely.
I hope that this resolves the issue for you.
Cheers
Nick
binutils/ChangeLog
2008-02-15 Chu Li <address@hidden>
Nick Clifton <address@hidden>
PR binutils/5713
* strings.c (integer_arg): Delete function.
(string_min): Initialise to 4.
(main): Use strtoul to parse integer arguments.
Move check for an invalid string length to after all the arguments
have been parsed.
(usage): Use indentation to indicate that -<n> is a another form
of the --bytes= command line option.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=5713
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
- [Bug binutils/5713] New: strings: use '-0' as option will meet infinite loop, chul at cn dot fujitsu dot com, 2008/02/01
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, chul at cn dot fujitsu dot com, 2008/02/01
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, hjl dot tools at gmail dot com, 2008/02/08
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, chul at cn dot fujitsu dot com, 2008/02/12
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, nickc at redhat dot com, 2008/02/14
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, nickc at redhat dot com, 2008/02/14
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, chul at cn dot fujitsu dot com, 2008/02/15
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, chul at cn dot fujitsu dot com, 2008/02/15
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, nickc at redhat dot com, 2008/02/15
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop,
nickc at redhat dot com <=
- [Bug binutils/5713] strings: use '-0' as option will meet infinite loop, chul at cn dot fujitsu dot com, 2008/02/17