bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/11983] libbfd reuses pointer passed to bfd_openr


From: tromey at redhat dot com
Subject: [Bug binutils/11983] libbfd reuses pointer passed to bfd_openr
Date: Fri, 03 Jan 2014 19:26:13 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=11983

--- Comment #12 from Tom Tromey <tromey at redhat dot com> ---
(In reply to Nick Clifton from comment #11)
> Hi Tom,
> 
> > On further reflection I think the patch as applied will
> > cause gdb crashes.  Due to the historical oddity of how
> > the BFD's filename was handled, gdb chose to go its own
> > route and reallocate the filename on the BFD's objalloc.
> 
> Hang on - are you saying that GDB alters the contents of the filename 
> field inside the BFD structure ?  If so, then surely the correct thing 
> to do now is to remove that piece of code from GDB.

Yeah, that's what gdb does.
I agree that it probably makes the most sense now to entirely remove
gdb_bfd_stash_filename (contra a suggestion I saw on the mailing list).
However it would be good to audit all the callers to be sure.
Sorry for the roundabout responses, I'm away from real email for the
time being.

-- 
You are receiving this mail because:
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]