[Bug binutils/27594] build processes broken by changed space handling

[martin at martin dot st]

https://sourceware.org/bugzilla/show_bug.cgi?id=27594

--- Comment #21 from Martin Storsjö <martin at martin dot st> ---
(In reply to Eli Zaretskii from comment #20)
> (In reply to Martin Storsjö from comment #19)
> > Up until the 2.35 version, the option was documented as "This option may be
> > used to specify the preprocessor to use, including any leading arguments.
> > The default preprocessor argument is `gcc -E -xc-header -DRC_INVOKED`." I
> > think that's rather clearly saying that this kind of behaviour was
> > explicitly intended and allowed?
> 
> So the incompatible change is in the documentation, right?  The code just
> does what the documentation says it should, right?

No; in 21c33bcbe36377abf01614fb1b9be439a3b6de20 (Nov 2020) the implementation
was changed to put full quotes around the string coming from --preprocessor;
this broke passing extra leading arguments (as previously was documented as
supported). In practice, popen() on windows might still have worked in some
cases, but it no longer did on unix (and cygwin).

In 5edb8e3f5ad8d74a83fc0df7f6e4514eed0aa77f (Apr 2021) the documentation was
changed to stop saying that "the default preprocessor argument is `gcc -E
-xc-header -DRC_INVOKED`". In 749c700282097cf679ff019a9674d7c762f48619 (May
2021), which was supposed to restore the original --preprocessor behaviour, it
further removed the statement that the --preprocessor option can be used to
specify other leading arguments to the preprocessor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.