[Bug ld/28040] libLLVM.so fails to link using LTO with ld.bfd + LLVMGold plugin

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28040

--- Comment #13 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The binutils-2_37-branch branch has been updated by H.J. Lu
<hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0f206424c11a7ef6eb45326aac5fb4ff41692ffd

commit 0f206424c11a7ef6eb45326aac5fb4ff41692ffd
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Jul 5 08:54:54 2021 -0700

    ld: Cache and reuse the IR archive file descriptor

    Linker plugin_object_p opens the IR archive for each IR archive member.
    For GCC plugin, plugin_object_p closes the archive file descriptor.  But
    for LLVM plugin, the archive file descriptor remains open.  If there are
    3000 IR archive members, there are 3000 file descriptors for them.  We
    can run out of file descriptors petty easily.

    1. Add archive_plugin_fd and archive_plugin_fd_open_count to bfd so that
    we can cache and reuse the IR archive file descriptor for all IR archive
    members in the archive.
    2. Add bfd_plugin_close_file_descriptor to properly close the IR archive
    file descriptor.

    bfd/

            PR ld/28040
            * archive.c (_bfd_archive_close_and_cleanup): Close the archive
            plugin file descriptor if needed.
            * bfd.c (bfd): Add archive_plugin_fd and
            archive_plugin_fd_open_count.
            * opncls.c (_bfd_new_bfd): Initialize to -1.
            * plugin.c (bfd_plugin_open_input): Cache and reuse the archive
            plugin file descriptor.
            (bfd_plugin_close_file_descriptor): New function.
            (try_claim): Call bfd_plugin_close_file_descriptor.
            * plugin.h (bfd_plugin_close_file_descriptor): New.
            * bfd-in2.h: Regenerated.

    ld/

            PR ld/28040
            * plugin.c (plugin_input_file): Add ibfd.
            (release_plugin_file_descriptor): New function.
            (release_input_file): Call release_plugin_file_descriptor to
            close input->fd.
            (plugin_object_p): Call release_plugin_file_descriptor to close
            input->fd.  Also call release_plugin_file_descriptor if not
            claimed.
            * testsuite/config/default.exp (RANLIB): New.
            * testsuite/ld-plugin/lto.exp: Run ranlib test.

    (cherry picked from commit 918172470430ea6fa082c941e6789add88331197)

-- 
You are receiving this mail because:
You are on the CC list for the bug.