bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/28303] objdump crashes in riscv_elf_add_sub_reloc


From: palmer at gcc dot gnu.org
Subject: [Bug binutils/28303] objdump crashes in riscv_elf_add_sub_reloc
Date: Mon, 06 Sep 2021 15:40:30 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=28303

Palmer Dabbelt <palmer at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |palmer at gcc dot gnu.org

--- Comment #3 from Palmer Dabbelt <palmer at gcc dot gnu.org> ---
I see a bunch of

  if (reloc_entry->address > bfd_get_section_limit (abfd, input_section))
    return bfd_reloc_outofrange;

in the MIPS port, which is subtly different than this.  I don't really care
which error value to pick, but I guess ">" is a touch better than ">=".

Like Nick said, the proposed solution is sort of just a hack.  Given that it
seems like a common idiom I'm fine with it, but it does seem preferable to
hoist this into some generic code (I'd be tempted to try and check the bounds
there, but IDK if that's sane).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]