[Bug ld/31179] RISC-V: The SET/ADD/SUB fix breaks ABI compatibility with 2.41 objects

[charlie at rivosinc dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31179

Charlie Jenkins <charlie at rivosinc dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charlie at rivosinc dot com

--- Comment #10 from Charlie Jenkins <charlie at rivosinc dot com> ---
>From a9eb35c3ee0eb265674d7858a8b4ec24928eae6e Mon Sep 17 00:00:00 2001
>From: Nelson Chu <nelson@rivosinc.com>
>Date: Wed, 20 Dec 2023 10:37:41 +0800
>Subject: [PATCH] RISC-V: PR31179, The SET/ADD/SUB fix breaks ABI compatibility
> with 2.41 objects
>
>* Problematic fix commit,
>2029e13917d53d2289d3ebb390c4f40bd2112d21
>RISC-V: Clarify the behaviors of SET/ADD/SUB relocations

...

>
>+              _bfd_error_handler (_("%pB: warning: R_RISCV_SUB_ULEB128 with"
>+                                    " non-zero addend, please rebuild by new"
>+                                    " binutils"), input_bfd);

Is it possible to provide a version number instead of saying "new"? Then you
could say something like "please rebuild using a binutils that is at least
version 2.42".

...

> PARSE_AND_LIST_OPTIONS=${PARSE_AND_LIST_OPTIONS}'
>   fprintf (file, _("  --relax-gp                  Perform GP relaxation\n"));
>   fprintf (file, _("  --no-relax-gp               Don'\''t perform GP 
> relaxation\n"));
>+  fprintf (file, _("  --check-uleb128             Check if SUB_ULEB128 with 
>non-zero addend\n"));

I think it is more clear here to replace "with" with "has".

>+  fprintf (file, _("  --no-check-uleb128          Don'\''t check if 
>SUB_ULEB128 with non-zero addend\n"));

Same thing here.
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.