[Bug gas/31284] scfi: untraceable control flow should be a hard error

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31284

--- Comment #1 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Indu Bhagat <ibhagat@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=91cdbed4d7b3acff951e0f21008a7775a7f23c20

commit 91cdbed4d7b3acff951e0f21008a7775a7f23c20
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Fri Jan 26 10:30:18 2024 -0800

    gas: scfi: untraceable control flow should be a hard error

    PR gas/31284

    Currently, if an indirect jump is seen, GCFG (a CFG of ginsns) cannot be
    created, and the SCFI machinery bails out with a warning:
      "Warning: Untraceable control flow for func 'foo'; Skipping SCFI"

    It is, however, better suited if this is a hard error.  Change it to a
    hard error.  Also change the message to skip mentioning "SCFI", because
    the error itself may also useful when ginsns are used for other passes
    (distinct from SCFI) involving GCFG, like a pass to detect if there is
    unreachable code.  Hence, simply say:
      "Error: untraceable control flow for func 'foo'"

    gas/
    PR gas/31284
            * ginsn.c (ginsn_data_end): Use as_bad instead of as_warn.

    gas/testsuite/
    PR gas/31284
            * gas/scfi/x86_64/ginsn-cofi-1.l: Adjust to the expected output
            in case of errors.
            * gas/scfi/x86_64/scfi-unsupported-cfg-1.l: Error not Warning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.