[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug ld/31466] It takes a long time to build Rust program with --no-keep
From: |
cvs-commit at gcc dot gnu.org |
Subject: |
[Bug ld/31466] It takes a long time to build Rust program with --no-keep-memory |
Date: |
Wed, 03 Apr 2024 16:17:53 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=31466
--- Comment #11 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3428c771aef0cebe229ac0f02a654d2ef78f2427
commit 3428c771aef0cebe229ac0f02a654d2ef78f2427
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Fri Mar 8 16:21:42 2024 -0800
elf: Always keep symbol table and relocation info for eh_frame
When --no-keep-memory is used, the symbol table and relocation info for
eh_frame are freed after they are retrieved for each text section in the
input object. If an input object has many text sections, the same data
is retrieved and freed many times which can take a very long time.
Update _bfd_elf_gc_mark to keep the symbol table and relocation info for
eh_frame to avoid it. Data to link the 3.5GB clang executable in LLVM
17 debug build on Linux/x86-64 with 32GB RAM is:
before after improvement
user 86.31 86.44 -0.2%
system 8.77 8.63 1.6%
total 95.58 96.81 -1.3%
maximum set(GB) 13.1 13.1 0%
page faults 3024752 3028699 -1.3%
and data to link the 275M cc1plus executable in GCC 14 stage 1 build is:
user 5.49 5.46 -0.5%
system 0.73 0.73 0%
total 6.26 6.25 0.3%
maximum set(MB) 964 964 0%
page faults 235173 235796 -0.3%
The memory usage impact is minimum and the link time of the Rust binary
in
https://sourceware.org/bugzilla/show_bug.cgi?id=31466
is reduced from 500+ seconds to 1.44 seconds, a 300x speedup.
PR ld/31466
* elflink.c (init_reloc_cookie): Add a bool argument, keep_memory,
for keeping memory. Always keep memory if keep_memory is true.
(init_reloc_cookie_rels): Likewise
(init_reloc_cookie_for_section): Add a bool argument for keeping
memory and pass it to init_reloc_cookie and
init_reloc_cookie_rels.
(_bfd_elf_gc_mark_reloc): Pass false to _bfd_elf_gc_mark.
(_bfd_elf_gc_mark): Pass true to init_reloc_cookie_for_section
for the eh_frame section. Pass false to
init_reloc_cookie_for_section for other sections.
(_bfd_elf_gc_mark_extra_sections): Add Add a bool argument for
keeping memory and pass it to _bfd_elf_gc_mark.
(bfd_elf_parse_eh_frame_entries): Pass false to init_reloc_cookie
and init_reloc_cookie_rels.
(bfd_elf_gc_sections): Pass false to init_reloc_cookie_for_section
and _bfd_elf_gc_mark.
(bfd_elf_discard_info): Pass false to
init_reloc_cookie_for_section and init_reloc_cookie.
--
You are receiving this mail because:
You are on the CC list for the bug.
- [Bug ld/31466] It takes a long time to build Rust program with --no-keep-memory,
cvs-commit at gcc dot gnu.org <=