[Bug binutils/31605] [readelf, -wL] Highlight empty address range

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31605

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nickc at redhat dot com

--- Comment #1 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Tom de Vries from comment #0)
Hi Tom,

> I wonder if making this clear somehow using an annotation would be a good
> idea.
> 
> Say:
> ...
> File name                    Line number    Starting address    View    Stmt
> 
> dw2-epilogue-begin.c                  44            0x4101e8               x
> dw2-epilogue-begin.c                  47           ~0x4101ec               x
> dw2-epilogue-begin.c                   -            0x4101ec

A tilde seems too mild/easily missible/not immediately obvious to me...

> Or displaying the address in parentheses.

This might be better.  But really it is not just the address that is not used,
it is the entire line of source code as well.  So maybe something like:

  dw2-epilogue-begin.c                  27            0x40110d               x
  [dw2-epilogue-begin.c                 28            0x401111               x]
  dw2-epilogue-begin.c                  29            0x401111       1       x
  dw2-epilogue-begin.c                  30            0x401118               x

Or:

  dw2-epilogue-begin.c                  27            0x40110d               x
  dw2-epilogue-begin.c (unused)         28            0x401111               x
  dw2-epilogue-begin.c                  29            0x401111       1       x
  dw2-epilogue-begin.c                  30            0x401118               x

Whatever way is chosen, it will have to be optional and off by default as
otherwise I am sure that it will break lots of things, not least of which is
gdb's own testsuite.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.