Re: more CVS build failures on RedHat 8

[Derek Robert Price]

Jim Salter wrote:

> I haven't worked out the patches for these, yet.  Sorry.  And if 
> there's a better person/email alias to send these failure notices to, 
> please let me know. 


<bug-cvs@gnu.org> is the appropriate list.  We also like to see these in 
the issues database on ccvs.cvshome.org for tracking purposes, but since 
more people are using bug-cvs at the moment, it is still useful to 
notify bug-cvs that a new issue has been created.  bug-cvs cc'd.

> CVS build failure with --disable-cvs-ndbm:
>
>    gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib -I../diff -I../zlib 
> -I/usr/kerberos/include    -g -O2 -c `test -f 'add.c' || echo './'`add.c
>    In file included from add.c:27:
>    cvs.h:151:18: ndbm.h: No such file or directory
>    In file included from add.c:27:
>    cvs.h:491: parse error before '*' token
>    cvs.h:491: warning: data definition has no type or storage class
>    cvs.h:600: parse error before '*' token
>    In file included from add.c:27:
>    cvs.h:706: parse error before '*' token 


I'd love to see an AC_REPLACE_FUNC style patch for this.  I looked into 
what it would take once and I don't think it would be overly 
complicated, but it wouldn't quite be trivial since the myndbm included 
with CVS and the ndbm library I looked at (gdbm?) don't implement the 
same API.

> CVS build failure: --disable-password-authenticated-client
>
>    gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib -I../diff -I../zlib 
> -I/usr/kerberos/include    -g -O2 -c `test -f 'client.c' || echo 
> './'`client.c
>    client.c:85: warning: `struct hostent' declared inside parameter list
>    client.c:85: warning: its scope is only this definition or 
> declaration, which is probably not what you want
>    client.c:139: warning: `struct hostent' declared inside parameter list
>    client.c: In function `connect_to_gserver':
>    client.c:4261: argument `hostinfo' doesn't match prototype
>    client.c:85: prototype declaration
>    client.c:4273: dereferencing pointer to incomplete type
>    client.c:4275: dereferencing pointer to incomplete type
>    make[2]: *** [client.o] Error 1 


Fix committed.

> CVS build failure: --without-editor
>
>    gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib -I../diff -I../zlib 
> -I/usr/kerberos/include    -g -O2 -c `test -f 'main.c' || echo 
> './'`main.c
>    main.c:60: `EDITOR_DFLT' undeclared here (not in a function) 


I'm not sure what behavior I would expect from compiling CVS without an 
editor.  I guess it could be rewritten to require log messages to be 
passed to the -F argument, but I'm not sure this is really very useful.

For now I checked in a fix to configure.in which errors out with the 
message:

   configure: error: CVS cannot be compiled without a default log 
message editor.
   Try `configure --with-editor'.

when run with --without-editor.

> CVS build failure: --without-tmpdir
>
>    configure: error: --with-tmpdir requires an absolute path. 


There's nothing wrong with this.  CVS needs somewhere to store temporary 
files.

> jim
>
> ---- script to loop through builds ----
> #!/bin/sh
> #
> # script to loop through options available to CVS build
> #
>
> echo ""
> echo "Initialize CVS source tree: ./noautomake.sh --noautoconf"
> ./noautomake.sh --noautoconf || exit 1
>        [ "${option}" != "${known_failure}" ] ||
>
> # options to test binary creation
> #
> options="
> --enable-rootcommit --disable-rootcommit
> --enable-client --disable-client
> --enable-server --disable-server
> --enable-dependency-tracking --disable-dependency-tracking
> --enable-cvs-ndbm --disable-cvs-ndbm
> --enable-password-authenticated-client 
> --disable-password-authenticated-client
> --enable-password-authenticated-server 
> --disable-password-authenticated-server
> --enable-server-flow-control --disable-server-flow-control
> --enable-encryption --disable-encryption
> --enable-force-editor --disable-force-editor
> --with-krb4 --without-krb4
> --with-gssapi --without-gssapi
> --with-rsh --without-rsh
> --with-default-rsh --without-default-rsh
> --with-editor --without-editor
> --with-tmpdir=/tmp/cvs/tmp --without-tmpdir
> --with-umask --without-umask
> --with-cvs-admin-group=cvs --without-cvs-admin-group
> --with-client --without-client
> --with-server --without-server
> "
>
> # remove entries from known_failures when build(s) succeed with that 
> option
> # add entries to known_failures when build(s) fail to get to the rest 
> of the options
> #
> known_failures=""
>
> for option in ${options} ; do
>
>    for known_failure in ${known_failures} ; do
>        [ "${option}" != "${known_failure}" ] || continue 2
>    done
>
>    echo ""
>    echo "Configure option: ${option}"
>    ./configure ${option} -quiet || exit 1
>
>    echo ""
>    echo "Testing build of checked out code in ${dir}"
>    make clean all
>    if [ $? -ne 0 ] ; then
>        echo ""
>        echo "ERROR: 'make' failed in ${dir} with option: ${option}"
>        echo ""
>        exit 1
>    fi
>
> done


Enjoy!

Derek

--
               *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
--
That liberty [is pure] which is to go to all, and not to the few or the rich
alone.
                        - Thomas Jefferson to H. Gates, 1798.