[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cvs has problems using LockDir when CVSROOT holds a symlink
From: |
Larry Jones |
Subject: |
Re: cvs has problems using LockDir when CVSROOT holds a symlink |
Date: |
Tue, 23 Sep 2003 16:28:23 -0400 (EDT) |
Mark D. Baushke writes:
>
> The 'make check' step is still running, but here is the patch in its
> current form.
Looks good, except I'd suggest moving expand_directory() to filesubr.c;
I can envision more general use for it in the future. I also have a
question: In parse_cvsroot(), why do you check for dirpath being NULL
before setting it? It looks to me like that condition is always true.
Also, if method isn't local_method we should probably skip the call to
expand_directory() and just dup the original string since only the
server can meaningfully expand the directory name.
-Larry Jones
I don't think that question was very hypothetical at all. -- Calvin
- cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Larry Jones, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Larry Jones, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink,
Larry Jones <=
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Larry Jones, 2003/09/23
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Derek Robert Price, 2003/09/24
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Mark D. Baushke, 2003/09/24
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Derek Robert Price, 2003/09/24
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Larry Jones, 2003/09/24
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Derek Robert Price, 2003/09/24
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Larry Jones, 2003/09/24
- Re: cvs has problems using LockDir when CVSROOT holds a symlink, Derek Robert Price, 2003/09/24