bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS update: MODIFIED: windows-NT ...


From: Derek Robert Price
Subject: Re: CVS update: MODIFIED: windows-NT ...
Date: Wed, 10 Dec 2003 16:10:57 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

mdb@cvshome.org wrote:

>  Index: ftello.c
>  ===================================================================
>  RCS file: /cvs/ccvs/lib/ftello.c,v
>  retrieving revision 1.1
>  retrieving revision 1.2
>  diff -u -b -r1.1 -r1.2
>  --- ftello.c    9 Dec 2003 09:59:42 -0000    1.1
>  +++ ftello.c    10 Dec 2003 20:43:36 -0000    1.2
>  @@ -18,6 +18,7 @@
>   #include <stdio.h>
>   #include <sys/types.h>
>   
>  +#if !defined(HAVE_FSEEKO) && !defined(ftello)
>   off_t
>   ftello (FILE *stream)
>   {
>  @@ -26,3 +27,4 @@
>   
>       return (off_t) pos;
>   }
>  +#endif /* !defined(HAVE_FSEEKO) && !defined(ftello) */


At the least, the !defined(HAVE_FSEEKO) part of this is unnecessary
since AC_LIBOBJ(ftello) won't be called and thus ftello.c compiled
unless fseeko wasn't found in the first place.

Also, the comments in the Autoconf definition of AC_FUNC_FSEEKO imply
that the existance or non-existance of ftello can be assumed by the
existance or non-existance of fseeko, so the !defined(ftello) should be
unnecessary as well.

>  1.60      +9 -1      ccvs/lib/system.h
>  
>
http://ccvs.cvshome.org/source/browse/ccvs/lib/system.h.diff?r1=1.59&r2=1.60
>  
>  (In the diff below, changes in quantity of whitespace are not shown.)
>  
>  Index: system.h
>  ===================================================================
>  RCS file: /cvs/ccvs/lib/system.h,v
>  retrieving revision 1.59
>  retrieving revision 1.60
>  diff -u -b -r1.59 -r1.60
>  --- system.h    9 Dec 2003 19:16:13 -0000    1.59
>  +++ system.h    10 Dec 2003 20:43:36 -0000    1.60
>  @@ -465,9 +465,17 @@
>   #define CVS_FNMATCH fnmatch
>   #endif
>   
>  -#ifndef HAVE_FTELLO
>  +#ifndef HAVE_FSEEKO
>  +
>  +#ifndef ftello


This may be redundant here as well - if the prototype exists, but the
linking failed, I think this #ifdef could avoid doubling the prototype?

>   off_t ftello (FILE *);
>   #endif
>  +
>  +#ifndef fseeko


Again, this may be redundant.

>  +int fseeko (FILE *, off_t, int);
>  +#endif
>  +
>  +#endif /* HAVE_FSEEKO */
>   
>   #if defined (__CYGWIN32__) || defined (WIN32)
>   /*


Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
- --
I don't know what's right any longer!  You have to think for both of us
- - for all of us!

        - Ingrid Bergman as Elsa, _Casablanca_
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQE/14vgLD1OTBfyMaQRAllSAJ9NO2IYAn7BpkNLe+f84QAl1F3/aACfZoEw
NRFxFJo2vvzKF4pBmm6rLRE=
=Yf2t
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]