Re: Stable CVS Version 1.11.13 Released!

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Edwards wrote:

>"Mark D. Baushke" <mdb@cvshome.org> wrote in message
news:mailman.2420.1076841826.928.bug-cvs@gnu.org...
>
>>>Looks like the mailing list to newsgroup is working
>>>again.  I wonder if it is still bidirectional?
>>
>>I have no idea. I suppose it will depend on where the
>>newsgroup gets its feed.
>
>
>If you received this via bug-cvs, then it means it is
>bidirectional.  I only read/post via the newsgroup.


bug-cvs was not delivering any mail up for about two months.  If the
gateway was down during that time, we wouldn't have known.

>>>I submitted this fix before, but I don't think it ever made
>>>it to your end.  I'm resubmitting against current version...
>>
>>The patch you submitted had whitespace problems. When I
>
>
>I don't know what causes the whitespace problems.  I am just
>using explorer, opening in notepad, then cut & paste into
>outlook express.  I've switched to unidiff in case that helps.
>
>I wish people didn't hold on so dear to tabs (in source
>code), they're a real pain.


I'd actually be up for changing them in the CVS source since the mix of
spaces and tabs makes it impossible to reset tab stops usefully anyhow,
but I'd prefer going to all tabs with a default tabstop of 4, which
would look the same.  :)

As for your cutting and pasting, one of your programs probably converted
the tabs into spaces and at first glance it looks like this patch has
the same problem.  I know that using netscape as an emailer and a diff
viewer, cutting and pasting from the browser window to the email window
preserves the tabs.  I'm not sure what other combinations work.

>>manually apply it to the TRUNK sources I see that it almost
>>immediately (sanity.sh test 95) triggers an assertion
>>failure in the RCS_checkout() function on line 3972:
>>
>>    assert (rev == NULL || isdigit ((unsigned char) *rev));
>>
>>with rev being garbage rather than NULL. This may be directly
>>traced to the fact that join_rev2 is NULL, but rev2 is not NULL
>>and contains garbage.
>
>
>I can see it is being freed early.  I have a new patch, with
>that stuff moved down.
>
>>If/when you have another version of the patch, feel free to
>>let us know. It would also be highly desirable for you to
>>include a suggested ChangeLog entry for the change and (if
>

Thanks for adding the ChangeLog entry and test cases, though I would
have preferred to see actualy sanity.sh test cases.  Could you try again
to get a patch to the list that preserves the tabs?

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAL775LD1OTBfyMaQRAq1XAJ42DABszDzWAgLN/t6421DxIuCSPACg95fK
H0VuHI4cC7WMU8DHxZ17BK8=
=iINb
-----END PGP SIGNATURE-----