Segmentation fault of cvs 1.11.13

[Reinhard Zierke]

Hi,

I've an issue with a Segmentation fault of cvs 1.11.11 up to 1.11.13.
If a parent directory of the CVS repository is accessible only but not
readable, cvs crashes with a segmentation fault:

-------------------------------------------------------------------------
rzdspc2% setenv CVSROOT /home/j2002/2foth/CVS
rzdspc2% ls -ld $CVSROOT
drwxrwxr-x  6 2foth    nats_3       512 Feb 24 10:49 /home/j2002/2foth/CVS/
rzdspc2% ls -ld /home/j2002
drwxr-x--x 249 root     j2002       4608 Feb 23 09:17 /home/j2002/

rzdspc2% cvs --version

Concurrent Versions System (CVS) 1.11.13 (client/server)

Copyright (c) 1989-2003 Brian Berliner, david d `zoo' zuhn, 
                        Jeff Polk, and other authors

CVS may be copied only under the terms of the GNU General Public License,
a copy of which can be found with the CVS distribution kit.

Specify the --help option for further information about CVS

rzdspc2% cvs checkout kvv2004
cvs [checkout aborted]: cannot readlink Segmentation fault
-------------------------------------------------------------------------

The segfault happens in the function xresolvpath() in line 941 of
src/filesubr.c:

-------------------------------------------------------------------------
    if ( ( hardpath = xgetwd() ) == NULL )
       error (1, errno, "cannot readlink %s", hardpath);
-------------------------------------------------------------------------

When hardpath == NULL, there isn't very much sense in using this
as an argument for the error call.

Apart from that, there are valid reasons for using directories that are
accessible but not readable.  CVS should be able to cope with this and
not complain that it cannot read the link.

Regards,
  Reinhard

-- 
Reinhard Zierke                       Universität Hamburg, FB Informatik
zierke@informatik.uni-hamburg.de      Vogt-Kölln-Straße 30, D-22527 Hamburg
postmaster@informatik.uni-hamburg.de  Tel.: (040) 42883-2295/2276 Fax: -2241