Re: Patch for cvs-1.12.1 -- enable_rootcommit

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bill Campbell wrote:

>The attached patch allows the --enable_rootcommit option to
>actually work as it's supposed to.

The option is --enable-rootcommit, use of --enable_rootcommit should
give you an error message.

Without your patch... in both the cvs-1.12.1 and cvs-1.12.6 sources...

If I './configure' without mention of the --enable-rootcommit option,
the config.h file will have a '#define CVS_BADROOT 1' line in it which
will put code into src/commit.c to disallow the euid == 0 (root) user
- From doing cvs commits. This is the documented default for the
- --enable-rootcommit option (disabled).

If I './configure --enable-rootcommit', the config.h file will have
a '/* #undef CVS_BADROOT */' line in it and there will be no check
added to the src/commit.c file, so commits by root will be allowed.

Your patch would therefore appear not to be needed.

What is the platform that is giving you problems?

        Thanks,
        -- Mark

>
>Bill
>--
>INTERNET:   bill@Celestial.COM  Bill Campbell; Celestial Software LLC
>UUCP:               camco!bill  PO Box 820; 6641 E. Mercer Way
>FAX:            (206) 232-9186  Mercer Island, WA 98040-0820; (206)
236-1676
>URL: http://www.celestial.com/
>
>Anyone who cannot cope with mathematics is not fully human.  At best he
>is a tolerable subhuman who has learned to wear shoes, bathe and not
>make messes in the house.
>        -- Lazarus Long, "Time Enough for Love"
>
>
>------------------------------------------------------------------------
>
>diff -uNr ../cvs-1.12.1-20030803/cvs-1.12.1/configure
./cvs-1.12.1/configure
>--- ../cvs-1.12.1-20030803/cvs-1.12.1/configure    2003-05-25
10:33:55.000000000 -0400
>+++ ./cvs-1.12.1/configure    2003-12-17 16:41:41.000000000 -0500
>@@ -12696,7 +12696,7 @@
> else
>   enable_rootcommit=no
> fi;
>-if test "$enable_rootcommit" = no; then
>+if test "$enable_rootcommit" = yes; then
>
> cat >>confdefs.h <<\_ACEOF
> #define CVS_BADROOT 1
>diff -uNr ../cvs-1.12.1-20030803/cvs-1.12.1/configure.in
./cvs-1.12.1/configure.in
>--- ../cvs-1.12.1-20030803/cvs-1.12.1/configure.in    2003-05-25
10:30:02.000000000 -0400
>+++ ./cvs-1.12.1/configure.in    2003-12-17 16:41:51.000000000 -0500
>@@ -944,7 +944,7 @@
>     [--enable-rootcommit],
>     [Allow the root user to commit files (disabled by default)]), ,
>   [enable_rootcommit=no])
>-if test "$enable_rootcommit" = no; then
>+if test "$enable_rootcommit" = yes; then
>   AC_DEFINE(
>     [CVS_BADROOT], [1],
>     [When committing a permanent change, CVS and RCS make a log entry of

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFAZxEg3x41pRYZE/gRAt6FAJ4751u8334biqR1ZmGgaF+8ZIH6xwCg0sbC
7ta7cwYWLEnK5VtP196rtAk=
=kqi7
-----END PGP SIGNATURE-----