[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Question: windows-NT/config.h Change #define realloc rpl_realloc
From: |
Derek Robert Price |
Subject: |
Re: Question: windows-NT/config.h Change #define realloc rpl_realloc |
Date: |
Mon, 05 Apr 2004 12:57:03 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I've moved this discussion to bug-cvs. This is the appropriate venue
for development discussions.
Conrad T. Pino wrote:
>Hi All,
>
>Being new to the project and coming from a Windoz background,
>I've been dabbling with building CVS with Visual C++ (VC) 6.0
>on the feature branch using the latest cvs.cvshome.org:/cvs
>*.dsp files. I've been looking at the warnings generated in
>the compile which led to questions about recent changes made
>in the feature branch.
>
>I noticed "windows-NT/config.h" and it's precursors were updated
>to add "#define realloc rpl_realloc" which might be the root of a
>warning message I'm studying.
>
>Before coming to a conclusion about the warning, I'd like to get
>a better understanding of the reasons the change was made. Can
>anyone shed some light here for me?
I don't recall exactly, but I think some behavior the GNULIB xmalloc or
xrealloc or something was expecting caused a crash on Windows.
Something to do with what happened when a NULL pointer was passed in or
somesuch. Check the email archives for a thread between Chris Bohn & I
discussing a patch he sent me. My browser is on the fritz and won't let
me get you a link, but the subject had "under Windows, cvs status
reports" in it.
- From src/ChangeLog:
2004-03-25 Derek Price <derek@ximbiot.com>
* client.c (send_file_names): Initialize string to NULL rather
than to
a single byte string containing only a null byte.
* subr.c (xrealloc_and_strcat): If the destination string is NULL,
simply allocate a new string.
(Original report from Chris Bohn <cbohn@rrinc.com>.)
If you are really a glutton for punishment, you could probably check out
the version from the 24th of March and reproduce the problem.
Derek
- --
*8^)
Email: derek@ximbiot.com
Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org
iD8DBQFAcY/eLD1OTBfyMaQRAl5bAJ90JLD2UPoD6OQ1dsg5TBOKAZoOggCdExJF
9JaBM6+vtsUxk42RpIbtrbo=
=yDz/
-----END PGP SIGNATURE-----
- Re: Question: windows-NT/config.h Change #define realloc rpl_realloc,
Derek Robert Price <=