Re: Windows Build: lib/regex.c warnings, "free" calls

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

>In general tracking external sources strikes me as a good idea.  In this
>case I'm concerned about what is done about the warnings on the feature
>branch until "somebody" appears to import the latest GNULIB version.
>
>I looked at the current state of regex in GNULIB.  Two versions are still
>there and both versions will generate the same "free" warnings as we have
>now.  Assuming we import a new version, I'm concerned about what is done
>about the warnings on the feature branch until the GNULIB maintainers do
>provide a fix for what could be a lame Microsoft compiler warning.


Well, for now, then, a quick fix may have to do.

>I reread HACKING but I'm not clear about which section applies.  If I've
>missed something important could you direct me to a line number?


You might not have.  I was just being thorough without anything
particular in mind.  Sorry.

>I checked "srclist.txt" and found nothing there about "regex".  Could you
>be more specific about what I should be seeking?


That means that the version of regex.c comes from before I started
maintaining srclist.txt.  srclist.txt will need to be updated after a
new version is imported.

>I'm assuming the suggested methodology for importing a new regex is to
>encourage "somebody" to volunteer.  I'm not qualified perform the task
>without mentoring and I'm reluctant to impose carelessly.


Well, if all that needs to be done is to figure out which version the
GNULIB folks are recommending and insert it into lib then run `make
check', then it should be easy.  Assuming it works.  If it fails then
more investigation may need to be done.

If it works, then the quick-fix should be applied there and submitted
back to GNULIB at the same time.

As for encouraging somebody to volunteer, it would certainly get it done
quicker.  :)

>I propose a common quick fix on both branches, additional work on other
>warnings and then a return to updating regex from GNULIB.
>
>>Derek
>
>
>Conrad
>
>==========================
>REGEX_FREE has 2 alternative definitions and just 1 reference:
>
>266     #define REGEX_FREE free
>299     #define REGEX_FREE(arg) ((void)0) /* Do nothing!  But inhibit
gcc warning.  */


Did you leave a "free" out here?

>4004    #define FREE_VAR(var) if (var) { REGEX_FREE (var); var = NULL;
} else
>==========================
>FREE_VAR has just 1 definition and 9 references:
>
>4004    #define FREE_VAR(var) if (var) { REGEX_FREE (var); var = NULL;
} else
>
>4008        FREE_VAR (regstart);                        \
>4009        FREE_VAR (regend);                            \
>4010        FREE_VAR (old_regstart);                        \
>4011        FREE_VAR (old_regend);                        \
>4012        FREE_VAR (best_regstart);                        \
>4013        FREE_VAR (best_regend);                        \
>4014        FREE_VAR (reg_info);                        \
>4015        FREE_VAR (reg_dummy);                        \
>4016        FREE_VAR (reg_info_dummy);                        \
>==========================
>FREE_VARIABLES has just 2 alternative definitions and 6 references:
>
>4005    #define FREE_VARIABLES()                        \
>4019    #define FREE_VARIABLES() ((void)0) /* Do nothing!  But inhibit
gcc warning.  */
>
>4260          FREE_VARIABLES ();
>4277          FREE_VARIABLES ();
>4434                  FREE_VARIABLES ();
>4450                  FREE_VARIABLES ();
>4508          FREE_VARIABLES ();
>5743      FREE_VARIABLES ();
>==========================


Huh?  What is this one doing?

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAc2b9LD1OTBfyMaQRAvDJAJ9+Z+9GQme0blCW75e9SbRwH5NCBgCg7t2O
HPtdGwm8IDLGj7syxeqx9OE=
=P9qT
-----END PGP SIGNATURE-----