bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Proposed Patch: Windows VC *.dsp Simplification


From: Conrad T. Pino
Subject: RE: Proposed Patch: Windows VC *.dsp Simplification
Date: Thu, 15 Apr 2004 19:26:44 -0700

Hi Derek,

> From: Derek Robert Price [mailto:derek@ximbiot.com]
> 
> Applied.  Thanks again.  Are these changes going to be permanent?

That is the goal.

Key .dsp file project setting statements are in 2 classes

        PROP name active-values ...
        ADD name active-values ...

where each of the above having a corresponding

        PROP BASE name reset-values...
        ADD BASE name reset-values...

FYI PROP/ADD name sets occur once per configuration (CFG=) value.

I edited to make named active-values equal their named reset-values.
This is why "Reset" button in "Settings..." won't be disruptive.

Removing child node overrides (per-file configurations) simplifies
future changes, visual auditing and smaller .dsp/.mak file sets.

> Assuming no one edits the per-file configurations, just opening them,
> futzing around a bit, perhaps adding a file, and resaving the *.dsp
> won't blow these edits away?

I tested adding a file case and VC6 behaves as we would like it too.

If "futzing around a bit" means just navigating "Settings..." without
changing values, compiling, "Export Makefile...", source file editing
then yes the simplification changes will persist.
-----
Changing "Settings..." values at top nodes will show up as changes to:

        PROP name active-values ...
        ADD name active-values ...

lines.  I suspect "BASE" statements can't be changed in IDE.

"Reset" "Settings..." at problem node will fix this case.
-----
Changing "Settings..." values at child nodes will show up as new:

        PROP name active-values ...
        ADD name active-values ...

lines enclosed within conditional statements once per CFG value.

"Reset" "Settings..." at parent or problem node will fix this case.
-----
Accidental changes that complicate the .dsp files should be pretty
obvious in "cvs diff" output and submitted patches.

> Derek

Conrad





reply via email to

[Prev in Thread] Current Thread [Next in Thread]