Re: Patch for timezone handling in cvs log

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bart Robinson wrote:

>On 2004-5-5 Derek Robert Price <derek@ximbiot.com> wrote:
> > Bart Robinson wrote:
> >
> > >On 2004-5-1 Derek Robert Price <derek@ximbiot.com> wrote:
> > > > Bart Robinson wrote:
> > > >
> > > > >Here is a simpler patch incorporating Derek's ideas with getting
> > > > >rid of the -z and omitting the gratuitous MT stuff in log.c.
> >
> >
> > Okay, Bart, almost ready to commit.  I'll probably commit your patch
> > almost as is to stable, but I have a question before I decide to
> > commit it to feature -
> >
> > I noticed in your comment that you say you copied tm_diff() directly
> > from the glibc strftime.c.  Why did you decide against actually using
> > strftime()?
> >
> > Derek
>
>I didn't consider using strftime.  The comment above that
>routine is verbatim from ../lib/getdate.y.  I wanted to use the
>one from getdate but it is static.
>
>Looking at strftime, it doesn't look like it would have been
>useful for what I was trying to do (diff two struct tm's).


No, but the POSIX 2004 strftime() would have rendered the diff moot
since it has a "%z" format string that it will replace with the offset
from GMT in -HHMM format.  I'm not sure if that was introduced in an
earlier POSIX version or not, but if it wasn't or if some platforms
have a broken strftime(), we should be able to rely on the GNULIB
strftime module.

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAmWpzLD1OTBfyMaQRAredAKCZ7S+YuUlh3XZvEX+yfaSiNmc0BgCg2NqT
8eDXmwzTcKduBlrh9ikeoH8=
=aZss
-----END PGP SIGNATURE-----