bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Windows Build Killer: Macro ISDIRSEP


From: Conrad T. Pino
Subject: Windows Build Killer: Macro ISDIRSEP
Date: Tue, 11 May 2004 14:31:35 -0700

Hi All,

Currently Windows build has no definition for subject
macro.  Previously subject macro was defined in file
"lib/system.h" until:

----------------------------
revision 1.68
date: 2004/04/27 21:07:59;  author: dprice;  state: Exp;  lines: +2 -12
Add dirname module from GNULIB.

* Makefile.am (libcvs_SOURCES): Add new files.
* basename.c, dirname.c, dirname.h: New files.
* stripslash.c: Update from GNULIB.
* system.h (ISDIRSEP): Remove.
(ISABSOLUTE): s/ISDIRSEP/ISSLASH/.  Use FILESYSTEM_PREFIX_LEN to search
for DOS drive spec rather than reimplementing.
* Makefile.in: Regenerated.
----------------------------

This macro looks like a candidate for "config.h" since:

   >grep -dn ISDIRSEP *.h
   File emx\config.h:
   252     #define ISDIRSEP(c) (FOLD_FN_CHAR(c) == '/')
   File os2\config.h:
   313     #define ISDIRSEP(c) (FOLD_FN_CHAR(c) == '/')

already exist but I'd appreciate feedback before committing
to this as a potential fix.

Question: Will the above implementation work for Windows?

Best regards,

Conrad Pino





reply via email to

[Prev in Thread] Current Thread [Next in Thread]