Re: advisory locks patch

[Paul Gelderblom (ptok)]

Mark D. Baushke wrote:
> For myself, I would find it desirable for someone to address what should
> happen if userA creates an advisory lock on moduleA/fileA.c on the
> mainline and userB tries to create an advisory lock on moduleA/fileA.c
> on some FOO_BRANCH branch of the mainline... the documentation seems to
> be silent on what should happen...

The current behaviour (*) is that the advisory lock pertains to all
branches. So userB will not be able to obtain
the lock: the advisory lock is global for the moduleA/FileA.c file.
An option to "lock" only a certain branch would defenitely be useful for
some users. But it is currently (*) not there
in the edit -c patch.
However, the patch as it is now is already useful to many. Being brach
specific would probably
increase the complexity of the code, and Derek has mentioned that the patch
is already rather large as it is now.
I would say: include the edit -c feature as it is now. Once it is is
included, and it gets used by more people, one of those may at some point
volunteer to make  it branch specific.

(*) that is, unless this has been changed since Noel Yap's version of this
patch. I don't think it has, Matthew should know  for sure.

Paul Gelderblom