bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: $Log$ substitution in binary files.


From: Mark D. Baushke
Subject: Re: $Log$ substitution in binary files.
Date: Fri, 10 Sep 2004 09:56:14 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Derek Robert Price <derek@ximbiot.com> writes:

> Mark D. Baushke wrote:
> 
> > Derek Robert Price <derek@ximbiot.com> writes:
> >
> > >Okay, but how much would you deem acceptable for 1.11.x?  
> >
> >
> > Hmmm... 8 to 16 Kbytes (RCS_BUFSIZE or MAX_BUF_SIZE) seems unlikely to
> > cause a regression with most current users.
> 
> 
> Are you proprosing an 8-16k limit on the expansion of any keyword or
> an 8-16k limit on the comment leader?

A comment leader that is determined by scanning backward for a '\n'
byte. I'd suggest that if no '\n' is found looking backward 16Kbytes,
just use the RCS comment character on stable.

> I have to admit, now that you remind me, I am reluctant to set any new
> limit on stable with so few reports out there. 

Yes, this was my point.

> Even a 256 byte limit on the comment leader seems unlikely to break
> anybody's setup, but users never cease to suprise me...

A 256 byte limit on stable is a bad idea because the users would be
stuck if they needed a higher limit to going in and doing a

   cvs admin -c 'really-long-text-prefix' filename

to 'fix' it given that they would not have a global CVSROOT/config knob
to twist.

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFBQdyu3x41pRYZE/gRAkn0AKDjgIQDfeqEh9KTiUW5BEpl7oLfWgCgxiBD
opZoMX/q+GsR52hCAQbmdmY=
=NNSy
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]