Re: CVS Feature Branch - Windows Build Broken - lib/xgethostname.c& WinSock

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Conrad,

Conrad T. Pino <Conrad@Pino.com> writes:

> The follow patch seems to work but it's definitely a hack and
> not a pretty one in my opinion.
> 
> Conrad
> 
> Index: windows-NT/unistd.h
> ===================================================================
> RCS file: /cvs/ccvs/windows-NT/unistd.h,v
> retrieving revision 1.3
> diff -u -p -r1.3 unistd.h
> --- windows-NT/unistd.h       6 Oct 2004 23:57:51 -0000       1.3
> +++ windows-NT/unistd.h       22 Nov 2004 18:31:51 -0000
> @@ -23,6 +23,7 @@
> 
>  int chdir (const char *path);
>  int close (int fd);
> +int __stdcall gethostname (char * name, int namelen);
> 
>  #if 0 /* someday maybe these should be added here as well */

I have been thinking about your hack. As a hack it is probably
'better' than forking xgethostname.c from the GNULIB folks. So,
if you are able to build the cvs.exe with this patch, I suggest
you go ahead and commit it. We can revisit it at such time as
we hear back from the GNULIB folks about possibly putting a
conditional '#include <winsock.h>' into xgethostname.c directly.

        Thanks,
        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFBpDqo3x41pRYZE/gRAlA2AKCgy8Y/2ZA8NlNvqUpWZP+jYXXnlwCgklsd
3KdErdtf2A403SCBBV/Szx8=
=M0JG
-----END PGP SIGNATURE-----