Re: [Fwd: problems trying to use both PAM and CVSROOT/passwd]

[Derek Price]

Brian Murphy wrote:

> This is a bug. When CVSROOT/passwd is used for authentication then the 
> PAM
> library is not initialized. When the pam_* functions are called in 
> switch_to_user
> they fail because pam_start has not been called.
>
> Solution:
>
> split out pam initialization to a seperate function which is always 
> called.
>
> patch attached.
>
> Please review and give your OK to submit.


You're using a different indentation style than the one specified in 
HACKING (what I spotted was where you put the open bracket which starts 
a new block after an `if').  It looks like you already got away with the 
new style at least once, and I'm not going to be a stickler, but if you 
have time to fix it, it would be nice to remain consistent.  Regardless, 
fixing the PAM support is more important than the indentation style.

Other than that, the patch looks fine to me.  Assuming it compiles and 
passes regression, feel free to commit it.

Cheers,

Derek