bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature request/ideas


From: Frank Hemer
Subject: Re: Feature request/ideas
Date: Mon, 28 Feb 2005 20:35:22 +0100
User-agent: KMail/1.5.1

> > | If tags with '@' at the begining are used they're added in the
> > | cvsnt way (I remember I wrote cvsnt wouldn't cache them but I was
> > | wrong). If the .commitid is used, they're cached as
> > | '.commitid.xxx', but this could be changed as you suggested.
> >
> > I think this would be a good idea, as otherwise the search of val-tags
> > will be run once for each possible form of the commitid.

Comming back on this issue:
In tag.c::tag_check_valid() there is a consistency check for symbolic tags 
before adding the tag to val-tags. Because this consistency-check now 
properly identifies the commitid tag, it usually would never be added to 
val-tags, and I don't see any other place where val-tags is accessed.
So I would assume not adding to val-tags makes no difference if the 
tag_check_valid() is never called for the commitid, even better, it saves 
some performance?
Do I miss sth.?

Regards,
Frank

-- 
- The LinCVS Team -
http:/www.lincvs.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]