[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: newtags
|
From: |
Derek Price |
|
Subject: |
Re: newtags |
|
Date: |
Tue, 19 Apr 2005 15:10:36 -0400 |
|
User-agent: |
Mozilla Thunderbird 1.0.2 (Windows/20050317) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Frank Hemer wrote:
> On Tuesday 19 April 2005 20:41, Derek Price wrote:
>
>>> I'd like to see my latest patch from 2005-04-08 18:03 beeing
>>> commited to the newtags branch so I can continue working on it
>>> ...
>>
>> Sorry. I ran the tests and saw them pass the other day but I had
>> been having a hard time finding the time to review your most
>> recent changes. After a quick scan of your latest work, it looks
>> to me like your changes are headed in the right direction. Some
>> of it is fairly obviously simplification. I am still wondering
>> whether there is a way to avoid handling magic numbers in so many
>> locations - like maybe it should have been abstracted out by this
>> portion of the code, but I haven't time for a full evaluation.
>>
>> Keep up the good work,
>
>
> I just updated:-)
>
> The number of locations is less than before starting the newtags
> branch - are you suggesting to also review and change the remaining
> locations?
No, if the number has been reduced by the new code, don't worry about
it unless you are in the mood. I just thought your latest change may
have added some magic number processing, though it is possible you
were only moving it.
> If so, I have the doc in mind saying magic numbers were added
> because of a performance gain. Is this still true or is that just a
> rcs-file parsing internal thing I don't have to bother about?
I believe this is an internal RCS file parsing issue, yes. RCS only
names and stores branches after the first commit to the branch. To
stick with this method, CVS would have had to check in a first empty
revision on each and every branch in the file at tag time, then attach
the branch to the new revisions. Instead, CVS only attaches the tag
to the "magic" revision in the symbols list, then creates the actual
branch (i.e. adds revisions to the branch), only when necessary.
Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCZVesLD1OTBfyMaQRAtYhAJ4v8Q3hRSN0izL/oduk8C2jiioNbwCcCs9k
MBZZ/ppToDtcaaPzESlNt00=
=7TDC
-----END PGP SIGNATURE-----