[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for making CommitID configurable
From: |
Mark D. Baushke |
Subject: |
Re: Patch for making CommitID configurable |
Date: |
Tue, 26 Apr 2005 00:25:08 -0700 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Derek Price <derek@ximbiot.com> writes:
> Peter Backes wrote:
> >On 21 Apr 2005 at 10:02, Derek Price wrote:
> >>I really want to make this the default behavior, even after an
> >>upgrade. Would this do the trick for you?
> >
> >What do you mean exactly? new->use_commit_id = true instead of
> >false, i.e. have commit IDs written even for old repositories after
> >an update? I'd not recommend this. It violates the principle of
> >least astonishment (like the current solution). However, at least it
> >was better than the current situation.
>
> I'm not sure I believe that. I think most people would prefer to not
> have to jump through any hoops to see new features enabled, especially
> when dealing with feature releases, and I don't think all that many
> people run RCS inside their CVS repositories anymore. Any dissenting
> opinions other than Peter's out there?
I am given to understand that WebCVS and ViewCVS can run 'rcs' commands
like rlog as a way to glean information out of the local repository
without running 'cvs' commands on the ,v files.
> Why is RCS whining anyhow? The spec leaves room for newphrases. Is it
> requesting an upgrade?
If you pass the -q switch to the RCS 5.7 commands, they will not whine
about unknown phrases. The warning message spews from the
rcs-5.7/src/rcslex.c::warnignore() function which is called from
rcs-5.7/src/rcslex.c::getphrases() when NextString is not one of the
known keywords.
A solution would be to ensure that the '-q' switch is being passed to
any rcs command that might run into a newphrase like 'commitid'
% rlog foo,v
rlog: foo,v: warning: Unknown phrases like `commitid ...;' are present.
...
% rcsdiff -r1.1 -r1.2 foo,v
rcsdiff: foo,v: warning: Unknown phrases like `newphrase ...;' are present.
===================================================================
RCS file: foo,v
retrieving revision 1.1
retrieving revision 1.2
diff -r1.1 -r1.2
26a27
> #
%
See also the threads here:
http://www.cvsnt.org/pipermail/cvsnt/2003-February/005206.html
http://mailman.lyra.org/pipermail/viewcvs/2003q1/001713.html
http://www.akhphd.au.dk/~bertho/cvsgraph/viewcvs.cgi/cvsgraph/rcsl.l?rev=1.6
One solution might be to modify lib/vclib/bincvs/__init__.py to
use commands like 'co', 'rlog' with different command-line args than
fp = self.rcs_popen('co', (rev_flag, full_name), 'rb')
fp = self.rcs_popen('rlog', args, 'rt', 0)
or the others that exist.
Another alternative might be to provide a patch to the RCS maintainer
to support any of the newphrase formats that CVS has introduced...
Enjoy!
-- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQFCbezU3x41pRYZE/gRAq2KAKCg9gtNeRyUVhgA1aSRMlpBL/m1QQCfSHPH
o1NmVR1kyrB/uucNfTBFeTA=
=pUMj
-----END PGP SIGNATURE-----
- Patch for making CommitID configurable, Peter Backes, 2005/04/21
- Re: Patch for making CommitID configurable, Derek Price, 2005/04/21
- Re: Patch for making CommitID configurable, Peter Backes, 2005/04/25
- Re: Patch for making CommitID configurable, Derek Price, 2005/04/25
- Re: Patch for making CommitID configurable,
Mark D. Baushke <=
- Re: Patch for making CommitID configurable, Peter Backes, 2005/04/26
- Re: Patch for making CommitID configurable, Mark D. Baushke, 2005/04/27
- Re: Patch for making CommitID configurable, Peter Backes, 2005/04/27
- Re: Patch for making CommitID configurable, Mark D. Baushke, 2005/04/27
- Re: Patch for making CommitID configurable, Peter Backes, 2005/04/27
- Re: Patch for making CommitID configurable, Mark D. Baushke, 2005/04/27
- Re: Patch for making CommitID configurable, Peter Backes, 2005/04/27
- Re: Patch for making CommitID configurable, Derek Price, 2005/04/27
- Re: Patch for making CommitID configurable, Peter Backes, 2005/04/27
- Re: Patch for making CommitID configurable, Derek Price, 2005/04/27