Re: Patch for making CommitID configurable

[Derek Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Backes wrote:

>Hello,
>
>On 27 Apr 2005 at 12:48, Mark D. Baushke wrote:
>
>>>(long)time(NULL), getpid(): not portable.
>>
>>That one requires supporting documentation.
>>
>>Which platforms do not provide them? CVSNT and CVS both use them
>>extensively across all of our supported platforms.
>
>
>I can only say that Standard C doesn't specify any type for time_t,
>it is entirely opaque and can be implemented as a struct. I think I
>have read some systems choose double. getpid() is POSIX.
>
>But it's not about CVS, it's about the file format. A portable file
>format should not contain any information which cannot be
>created/processed in a portable way.


This information doesn't need to be processed in any non-opaque way once
created, but uniqueness is an argument.  Once created, it can be passed,
basically, as a tag to CVS, at which point only uniqueness matters. not
where the unique value came from.

>>>I guess -k and mergepoint are only being written on user request.
>>
>>It happens when users do a 'cvs update -j branch-tag' command. See
>>http://www.cvsnt.org/wiki/MergePoint for details. So, it is not really
>>very explicit on the part of the user in some sense.
>
>
>Then if it should be implemented in CVS, IMO it should be done a way
>that makes it's creation more explicit.


The whole point of commitid and mergeid is that they implement
auto-tracking functionality that CVS didn't use to have but many users
have requested and/or wished for at one time or another.  I really
dislike the idea of making the user request it be enabled, unless there
is a darn good reason.  I do not yet consider a few warning messages
from RCS a darn good reason.

Cheers,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCcA38LD1OTBfyMaQRArTfAJ0UvTPqAdF85vb710uD8HelvXxMvQCeIsrt
0OhkkL/n+ohpnoTENAdMZtE=
=/0gB
-----END PGP SIGNATURE-----