bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature Branch Windows Build Broken - New GNULIB glob module


From: Derek Price
Subject: Re: Feature Branch Windows Build Broken - New GNULIB glob module
Date: Tue, 17 May 2005 10:45:08 -0400
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

>The following patch lets me get this far in the Windows IDE build:
>--------------------Configuration: libcvs - Win32 Debug--------------------
>Compiling...
>glob.c
>H:\Conrad\Projects\cvs-1.12\lib\glob.c(253) : warning C4028: formal
parameter 1 different from declaration
>H:\Conrad\Projects\cvs-1.12\lib\glob.c(253) : warning C4028: formal
parameter 4 different from declaration
>H:\Conrad\Projects\cvs-1.12\lib\glob.c(668) : warning C4090: 'function'
: different 'const' qualifiers
>H:\Conrad\Projects\cvs-1.12\lib\glob.c(668) : warning C4024: 'getpwnam'
: different types for formal and actual parameter 1
>H:\Conrad\Projects\cvs-1.12\lib\glob.c(739) : warning C4013:
'glob_pattern_p' undefined; assuming extern returning int
>H:\Conrad\Projects\cvs-1.12\lib\glob.c(334) : fatal error C1600:
unsupported data type
>Error executing cl.exe.
>
>cvs.exe - 1 error(s), 5 warning(s)
>===================================================================
>The following patches do the following:
>
>1. Add WIN32 conditional #defines to "lib/glob_.h" to hide compile
>errors.
>
>2. Modify "lib/libcvs.dsp" to make "lib/glob.h" file
>from "lib/glob_.h" file.
>
>3. Modify Modify "lib/libcvs.dsp" to build "lib/glob.c" which is
>where the compile is failing after my hacks to "lib/glob_.h" file.
>===================================================================
>Index: lib/glob_.h
>===================================================================
>RCS file: /cvs/ccvs/lib/glob_.h,v
>retrieving revision 1.5
>diff -u -p -r1.5 glob_.h
>--- lib/glob_.h 15 May 2005 16:44:04 -0000 1.5
>+++ lib/glob_.h 17 May 2005 04:18:51 -0000
>@@ -19,6 +19,12 @@
> #ifndef _GLOB_H
> #define _GLOB_H 1
>
>+#ifdef WIN32
>+#define __BEGIN_DECLS
>+#define __END_DECLS
>+#define __const const
>+#endif


I'm going to suggest something a little more general to the GNULIB
maintainers:

#ifndef __BEGIN_DECLS
# define __BEGIN_DECLS
#endif
#ifndef __END_DECLS
# define __END_DECLS
#endif
#ifndef __const
# define __const const
#endif

I won't comment on the Windows build stuff - it sounds like you are
mirroring what the UNIX build is doing, but otherwise I prefer to stay
out of it.

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCigN0LD1OTBfyMaQRAnTvAJsHGOa5tqkD9crYZZ1/lFoYrsIS4QCgkChQ
eVG7KDjY6HnZUNK+LuIeUP0=
=FheJ
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]