RE: Feature Branch Solaris Build Broken - lib/glob.c errors

[Conrad T. Pino]

Hi Derek,

> From: Derek Price
> 
> >1. #include <sys/stat.h> within glob_.h file.
> 
> This would be the way to go.  You may commit this if you wish.

I committed an inclusion immediately before "struct stat" forward
declaration to assure the Solaris "stat" macro is used but on 2nd
reflection the forward declaration is moot.  I'm considering it's
removal.  Any objection on your part?

> >2. Move #include <glob.h> below #include <sys/stat.h> in glob.c file.
> 
> This is incorrect.  The GNULIB convention is to include a module's
> header immediately following the include of <config.h> in its associated
> source file (i.e. glob.c first including config.h then immediately
> including glob.h) to test the module's interface.

Thank you.

> Regards,

Ditto,

> Derek

Conrad