Re: [Cvs-cvs] Changes to ccvs/windows-NT/config.h.in.in

[Jim Hyslop]

Derek Price wrote:
> Jim Hyslop wrote:
>
>
> > Index: ccvs/windows-NT/config.h.in.in
> > diff -u ccvs/windows-NT/config.h.in.in:1.37 ccvs/windows-NT/config.h.in.in:1.38
> > --- ccvs/windows-NT/config.h.in.in:1.37 Fri Jun 10 20:32:21 2005
> > +++ ccvs/windows-NT/config.h.in.in      Thu Aug  4 01:00:40 2005
> > @@ -204,6 +204,8 @@
> >   */
> > #define HAVE_DECL_GETCWD 1
> >
> > +#define HAVE_GETCWD 1
>
>
> Jim, why did you do this?  HAVE_GETCWD isn't used anywhere I can see. 
> HAVE_DECL_GETCWD isn't even, directly, though it appears to be set
> correctly.

HAVE_GETCWD is used in lib\xgetcwd.c:

#if HAVE_GETCWD
char *getcwd ();
#else
# include "pathmax.h"
# define INITIAL_BUFFER_SIZE (PATH_MAX + 1)
char *getwd ();
# define getcwd(Buf, Max) getwd (Buf)
#endif

Without HAVE_GETCWD, I get a link error in the MSVC IDE:
Linking...
libdiff.lib(xgetcwd.obj) : error LNK2001: unresolved external symbol _getwd
.\WinDebug\cvs.exe : fatal error LNK1120: 1 unresolved externals


> Also, windows-NT/config.h.in and windows-NT/config.h are supposed to be
> autogenerated using the windows-NT/mkconfig.pl script, from ./config.h
> and windows-NT/config.h.in.in.  I'm not sure if that still needs to be
> done on UNIX or if Conrad added MSVC targets in the build files for it.

I wasn't sure exactly how it got generated, so I made the changes 
manually in all the files. I didn't see anything that built config.h.

So, is the correct procedure to modify config.h.in.in and run 
mkconfig.pl? I haven't seen any documentation that describes how to 
regenerate windows-NT/config.h; I assumed it was manually maintained.

--
Jim