Re: OpenVMS and CVS-1_11_21 client

[Piet Schuermans]

Derek

I checked the stable (non-feature) release cvs-1_11_21 downloadable  
from http://download.savannah.nongnu.org/releases/cvs/source/stable/ 
1.11.21/cvs-1.11.21.tar.gz      28-Sep-2005 13:23  3.3M

in this set the [.src]client.c contains select() calls

static void
handle_m (args, len)
    char *args;
    int len;
{
    fd_set wfds;
    int s;

    /* In the case where stdout and stderr point to the same place,
       fflushing stderr will make output happen in the correct order.
       Often stderr will be line-buffered and this won't be needed,
       but not always (is that true?  I think the comment is probably
       based on being confused between default buffering between
       stdout and stderr.  But I'm not sure).  */
    fflush (stderr);
    FD_ZERO (&wfds);
    FD_SET (STDOUT_FILENO, &wfds);
    errno = 0;
    s = select (STDOUT_FILENO+1, NULL, &wfds, NULL, NULL);
    if (s < 1 && errno != 0)
        perror ("cannot write to stdout");
    fwrite (args, len, sizeof (*args), stdout);
    putc ('\n', stdout);
}


The latest cvs1-11-x-branch from savannah.nongnu.org:/cvsroot/cvs   
has NO select() calls in the client.c
static void
handle_m (char *args, size_t len)
{
    /* In the case where stdout and stderr point to the same place,
       fflushing stderr will make output happen in the correct order.
       Often stderr will be line-buffered and this won't be needed,
       but not always (is that true?  I think the comment is probably
       based on being confused between default buffering between
       stdout and stderr.  But I'm not sure).  */
    fflush (stderr);
    fwrite (args, sizeof *args, len, stdout);
    putc ('\n', stdout);
}


I did not check the full feature releases.

Piet Schuermans.



On Dec 07, 2005, at 20:17, Derek R. Price wrote:

> Mark D. Baushke wrote:
>
> > btw: Derek is the one who has been working on the problems associated
> > with select() and a non-blocking/blocking I/O problem with OpenSSH as
> > transport... I have not looked closely at that code recently.
>
> I believe all the selects in client.c have been removed in the  
> latest stable and feature versions of CVS.  I don't recall if this  
> is true of any releases yet.
>
> Derek
>
> --
> Derek R. Price
> CVS Solutions Architect
> Ximbiot <http://ximbiot.com>
> v: +1 717.579.6168
> f: +1 717.234.3125
> <derek@ximbiot.com>