bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

build warnings in latest CVS build


From: Jim Salter
Subject: build warnings in latest CVS build
Date: Mon, 07 Aug 2006 19:46:00 -0700
User-agent: Thunderbird 1.5.0.5 (Windows/20060719)

Configure option: --enable-client ...

util.c: In function `finish_output':
util.c:311: warning: implicit declaration of function `waitpid'
add.c: In function `build_entry':
add.c:946: warning: implicit declaration of function `fputs_unlocked'

Configure option: --enable-server ...

util.c: In function `finish_output':
util.c:311: warning: implicit declaration of function `waitpid'
add.c: In function `build_entry':
add.c:946: warning: implicit declaration of function `fputs_unlocked'

...

Fix for fputs_unlocked() warning appears messy as you've got lib/unlocked-io.h included by cvs.h, but in lib/getpass.c, you've got the unlocked IO redeclared, so it seems like it would make more sense to have the following and remove the redeclaration code in lib/getpass.c:

Index: src/cvs.h
===================================================================
RCS file: /sources/cvs/ccvs/src/cvs.h,v
retrieving revision 1.349
diff -b -c -r1.349 cvs.h
*** src/cvs.h   26 Jul 2006 09:52:56 -0000      1.349
--- src/cvs.h   8 Aug 2006 02:43:21 -0000
***************
*** 33,39 ****
--- 33,41 ----
 #include "strcase.h"
 #include "stat-macros.h"
 #include "timespec.h"
+ #if USE_UNLOCKED_IO
 #include "unlocked-io.h"
+ #endif
 #include "xalloc.h"
 #include "xgetcwd.h"
 #include "xreadlink.h"

Fix for util.c warning appears to require including cvs.h, but if that's not what is wanted, defines like the waitpid() function need to be moved out of cvs.h into it's own header:

Index: diff/Makefile.am
===================================================================
RCS file: /sources/cvs/ccvs/diff/Makefile.am,v
retrieving revision 1.7
diff -b -c -r1.7 Makefile.am
*** diff/Makefile.am    14 Dec 2004 14:49:58 -0000      1.7
--- diff/Makefile.am    8 Aug 2006 02:36:04 -0000
***************
*** 13,19 ****
 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 ## GNU General Public License for more details.

! INCLUDES = -I$(top_srcdir)/lib -I$(top_builddir)/lib

 noinst_LIBRARIES = libdiff.a

--- 13,19 ----
 ## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 ## GNU General Public License for more details.

! INCLUDES = -I$(top_srcdir)/lib -I$(top_builddir)/lib -I$(top_srcdir)/src

 noinst_LIBRARIES = libdiff.a

Index: diff/util.c
===================================================================
RCS file: /sources/cvs/ccvs/diff/util.c,v
retrieving revision 1.13
diff -b -c -r1.13 util.c
*** diff/util.c 2 Feb 2003 19:52:38 -0000       1.13
--- diff/util.c 8 Aug 2006 02:36:04 -0000
***************
*** 16,21 ****
--- 16,22 ----
 */

 #include "diff.h"
+ #include "cvs.h"

 #if __STDC__
 #include <stdarg.h>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]