Re: problem compiling CVS with --disable-password-authenticated-client --without-gssapi

[Mark D. Baushke]

Hi Jim,

Jim Salter <jsalterjim@earthlink.net> writes:

> Configure options: --disable-password-authenticated-client --without-gssapi
> 
> client.c:118: warning: `struct hostent' declared inside parameter list
> client.c:118: warning: its scope is only this definition or
> declaration, which is probably not what you want
> client.c: In function `get_port_number':
> client.c:4330: warning: implicit declaration of function `getservbyname'
> client.c:4330: warning: assignment makes pointer from integer without a cast
> client.c:4331: warning: implicit declaration of function `ntohs'
> client.c:4331: error: dereferencing pointer to incomplete type
> client.c: In function `get_proxy_port_number':
> client.c:4393: error: `CVS_PROXY_PORT' undeclared (first use in this
> function)
> client.c:4393: error: (Each undeclared identifier is reported only once
> client.c:4393: error: for each function it appears in.)
> make[2]: *** [client.o] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2

Thank you for your problem report.

I have committed the following patch to address this problem. 

        -- Mark

Index: ChangeLog
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/ChangeLog,v
retrieving revision 1.3491
diff -u -p -r1.3491 ChangeLog
--- ChangeLog   6 Sep 2006 17:13:36 -0000       1.3491
+++ ChangeLog   6 Sep 2006 17:48:44 -0000
@@ -1,6 +1,12 @@
 2006-09-06  Mark D. Baushke  <mdb@gnu.org>
 
+       * client.h (HAVE_NETDB_H): Explicitly include netdb.h to get
+       'struct hostent' even when --disable-password-authenticated-client
+       and --without-gssapi are used.
+       (CVS_PROXY_PORT): Define outside of AUTH_CLIENT_SUPPORT and
+       HAVE_GSSAPI.
        * buffer.h (buf_count_mem): Provide if defined (PROXY_SUPPORT).
+       (Problems reported by Jim Salter <jsalterjim@earthlink.net>.)
 
 2006-09-06  Derek Price  <derek@ximbiot.com>
 
Index: client.h
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/client.h,v
retrieving revision 1.62
diff -u -p -r1.62 client.h
--- client.h    24 Apr 2006 18:50:26 -0000      1.62
+++ client.h    6 Sep 2006 17:48:45 -0000
@@ -20,6 +20,10 @@
 #include <sys/types.h>
 #include "root.h"
 
+/* Needed for struct hostent */
+#ifdef HAVE_NETDB_H
+#include <netdb.h>
+#endif
 
 
 /* Stuff shared with the server.  */
@@ -76,11 +80,12 @@ void connect_to_pserver (cvsroot_t *, st
 #   ifndef CVS_AUTH_PORT
 #     define CVS_AUTH_PORT 2401
 #   endif /* CVS_AUTH_PORT */
-#   ifndef CVS_PROXY_PORT
-#     define CVS_PROXY_PORT 8080
-#   endif /* CVS_AUTH_PORT */
 # endif /* (AUTH_CLIENT_SUPPORT) || defined (HAVE_GSSAPI) */
 
+# ifndef CVS_PROXY_PORT
+#   define CVS_PROXY_PORT 8080
+# endif /* CVS_PROXY_PORT */
+
 # if HAVE_KERBEROS
 #   ifndef CVS_PORT
 #     define CVS_PORT 1999