Re: heres my contribution to cp

[Richard Dawe]

Hello.

kza wrote:
> This is no bug, but I added a feature to cp that lets us see the speed,
> eta, etc during long or slow network (or tape device) copies.
[snip]
> I have patched it against the fileutils 4.1 source, and uses the -o flag
> to turn it on.  It is available here:
> 
> http://cratos.ath.cx/~kza/cp.patch
>
> I still have these things to do:
> 1. Similar mod to mv
> 2. Relevant man page changes
> 3. Must set up a signal handler that traps a kill or term and turns the
> cursor back on.
> 4. Find a better format for output display, or possibly let the use
> supply a format string.
[snip]

I have some comments:

* The display string is inconsistent:

    %.2f/%.2f Megs,  %.2f%% through, %.2fKB/s (%.2fMb/s),  %.2fs to go

I think you should change it so: Megs -> MB, Mb/s -> MB/s. Also, two spaces
after each comma wastes too much screen space.

* The total_size function may use the 'sb' variable before it's been
initialised. Also, is there any point in having two stat buffers - sb and sbx.
total_size() doesn't check for failure on calls to: opendir, readdir, chdir.
Does it cope with symlink loops?

* I think you should always update cpstats, except for the costly operations
(total_size(), etc.). In other words, always increment copied_so_far and other
counters like that.

Why do you disable the cursor? Does it cause a lot of flicker, when you do the
progress display, if the cursor is enabled?

A progress display is a nice feature IMNSHO.

Regards,

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]