bug#5840: 24.0.50; wrong tramp-file-name-regexp

[Thierry Volpiatto]

Michael Albinus
<albinus@detlef.i-did-not-set--mail-host-address--so-tickle-me> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> (For the records, I also dislike Tramp's syntactic ambiguity. But this is
>>> history, I guess we cannot change it anymore.)
>>
>> Everything can be changed.
>
> Maybe we can discuss it in another thread.
>
>>> In order to fix this problem, one could tweak
>>> `minibuffer-completion-predicate' in `minibuffer-completion-help',
>>> which is `file-exists-p' in the given case.
>>
>> I think we somehow need to make the error a bit more quiet.
>> Most of it needs to be done on Tramp's side, but maybe we can help it by
>> having the completion code warn Tramp that this is only used
>> for completion.  Or maybe the completion code can catch the error and
>> just display it calmly.
>
> Thanks for reminding me! We have had the same problem in ido.el (and
> icycles.el, IIRC), and I have introduced `tramp-completion-mode' exactly
> for this purpose.
>
> The appended patch shall fix it; Thierry, could you, please, test? You
> need a `make bootstrap', because minibuffer.el is dumped into the binary.
Just tested your patch.
Yes it work fine. :-)
It propose similar completion on /su: than `anything-create-tramp-name'.

,----
| Possible completions are:
| su:localhost:
| su:root@
| su:my.network:
`----

Thank you.

> === modified file 'lisp/minibuffer.el'
> *** lisp/minibuffer.el        2010-03-24 18:02:56 +0000
> --- lisp/minibuffer.el        2010-04-12 03:48:02 +0000
> ***************
> *** 1028,1034 ****
>     "Display a list of possible completions of the current minibuffer 
> contents."
>     (interactive)
>     (message "Making completion list...")
> !   (let* ((start (field-beginning))
>            (string (field-string))
>            (completions (completion-all-completions
>                          string
> --- 1028,1035 ----
>     "Display a list of possible completions of the current minibuffer 
> contents."
>     (interactive)
>     (message "Making completion list...")
> !   (let* ((tramp-completion-mode t)
> !      (start (field-beginning))
>            (string (field-string))
>            (completions (completion-all-completions
>                          string
>
>>         Stefan
>
> Best regards, Michael.
>
>
>
>
>

-- 
Thierry Volpiatto
Gpg key: http://pgp.mit.edu/