bug#7905: 24.0.50; VC not updating file status properly anymore after commit from vc-dir

[Tim Van Holder]

On 31 January 2011 11:31, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Tim Van Holder <tim.vanholder@gmail.com> writes:
>
>> $ grep foo CVS/Entries
>> /foo/1.297.2.24/Mon Jan 31 08:30:58 2011//Tmytag
>> $ stat foo
>> Modify: 2011-01-31 09:30:58.000000000 +0100
>
> Those are the same time stamp.
>
> Andreas.

Yes, but they end up not comparing as equal in VC.

Given a similar file but with CVS/Entries having "Tue Jan 11 15:18:16
2011" and stat giving "2011-01-11 16:18:16 +0100", edebugging
vc-cvs-parse-entry gets:

"time" as "Tue Jan 11 15:18:16 2011" (from matching its CVS/Entries line).
"mtime" as (19756 29880) (from "(nth 5 (file-attributes <file>))")
"parsed-time" as (16 18 15 11 1 2011 2 nil 0) (from parse-time on
value of "time")

It then has a check
    (equal mtime (apply 'encode-time parsed-time))
which returns nil; the apply yields (19756 26280), which is indeed not
the same as (19756 29880).

Checking the behaviour of (encode-time) I see that
  (encode-time 16 18 15 11 1 2011 2 nil 3600)
  (encode-time 16 18 15 11 1 2011 2 nil 0)
both return the same value "(19756 26280)" (which decodes as "(16 18
15 11 1 2011 2 nil 3600)").
This strikes me as odd since encode-time explicitly says that it
treats the last argument as timezone offset, suggesting that it cares
about it.